Enabled / disabled rules in LT server

jaumeortola · May 11, 2017, 4:07pm

Hi,

Currently, a LT server can be run using a languagetool.cfg file for setting enabled and disabled rules. But in this server when you use enabledRules and disabledRules via API, the rules in languagetool.cfg are forgotten.

See:

github.com

languagetool-org/languagetool/blob/master/languagetool-server/src/main/java/org/languagetool/server/TextChecker.java#L108


      
          PipelinePool pipelinePool; // mocked in test -> package-private / not final
          
          
TextChecker(HTTPServerConfig config, boolean internalServer, Queue<Runnable> workQueue, RequestCounter reqCounter) {
            this.config = config;
            this.workQueue = workQueue;
            this.reqCounter = reqCounter;
            if (config.isLocalApiMode()) {
              this.languageIdentifier = LanguageIdentifierService.INSTANCE.getSimpleLanguageIdentifier(config.preferredLanguages);
            } else {
              this.languageIdentifier = LanguageIdentifierService.INSTANCE.getDefaultLanguageIdentifier(
                      0,
                      config.getNgramLangIdentData(),
                      config.getFasttextBinary(),
                      config.getFasttextModel());
            }
            this.executorService = LtThreadPoolFactory.createFixedThreadPoolExecutor(
              LtThreadPoolFactory.TEXT_CHECKER_POOL,
              config.getMaxTextCheckerThreads(), config.getMaxTextCheckerThreads(),
              config.getTextCheckerQueueSize(),
              60L, false, (thread, throwable) -> {
                log.error("Thread: " + thread.getName() + " failed with: " + throwable.getMessage());

and

github.com

languagetool-org/languagetool/blob/master/languagetool-server/src/main/java/org/languagetool/server/TextChecker.java#L260


      
          
          
String requestId = httpExchange.getRequestHeaders().getFirst("X-Request-ID");
          
          
// logging information
          String agent = params.get("useragent") != null ? params.get("useragent") : "-";
          Long agentId = null, userId = null;
          if (databaseLogger.isLogging()) {
            DatabaseAccess db = DatabaseAccess.getInstance();
            agentId = db.getOrCreateClientId(params.get("useragent"));
            userId = limits.getPremiumUid();
          }
          String referrer = httpExchange.getRequestHeaders().getFirst("Referer");
          String userAgent = httpExchange.getRequestHeaders().getFirst("User-Agent");
          
          
if (!config.isAnonymousAccessAllowed() && limits.getPremiumUid() == null) {
            throw new AuthException("Anonymous access is prohibited on this server, please provide authentication.");
          }
          
          
int length = aText.getPlainText().length();
          if ("true".equals(params.get("languageChanged"))) {
            log.info("languageChanged to " + params.get("language") + " for text with length " + aText.getPlainText().trim().length());

I need another behavior. I need the default rules in the configuration file to be remembered (as a new “default”) and the enabledRules/disabledRules to be added to this “new default”. I think this behavior is more reasonable.

Is it OK to implement it? I can try to do it myself, but the logic of enabled and disabled rules is getting complicated, and I am not sure how it will affect other parts of the program. (Does the stand-alone LT use this code?)

dnaber · May 11, 2017, 6:08pm

I agree that the behavior you suggest sounds more sensible, so feel free to implement it. If you do, it should be the only behavior, i.e. there shouldn’t be a mode that still offers the old behavior. Does anybody remember why we implemented it the way it currently is?

jaumeortola · May 13, 2017, 5:24pm

Done here: server: use config file as new default rules · languagetool-org/languagetool@4905d6f · GitHub