Problem with nightly diff?

Development
1

Hello @dnaber

Two nightlies ago I created a rule that produced hundreds of false positives in PT.

I fixed the rule yesterday morning, but the nightly diff doesn’t report any changes in the results.

In fact, all languages are said to “no changes”:

Changes 2020-04-16 22:45 to 2020-04-17 22:45
Version: 5.0-SNAPSHOT (2020-04-16 18:47)
Latest Commit: Date: Fri Apr 17 19:32:13 2020 +0200
Not changed: en
Not changed: de
Not changed: fr
Not changed: ru
Not changed: uk
Not changed: ca
Not changed: pl
Not changed: pt-PT
Not changed: pt-BR
Not changed: gl
Not changed: es
Not changed: nl
Not changed: br
Not changed: eo

What happened?

Thanks!

2

The test cases failed, so the diff is empty.

3

Was the problem this commit? [es] disable wikipedia rule · languagetool-org/languagetool@88976a8 · GitHub

What time of day do tests start? I will take care to ensure that there are no errors at this time.

4

@dnaber

Will tonight’s diff reflect the changes not shown last night?

5

No, it was caused by one of my commits where a synchronized was missing (causing the test to sometimes fail, sometimes work).

Currently around 20:30 CET. But the better approach is to make sure the tests always work by running them before pushing changes. Maven tips - LanguageTool Wiki contains some tips to speed up the tests.

6

All that is known to me. But unexpected things always happen. In my case, it was a file present in my local files (tests were OK), but not added to GitHub.